636 add homogenization schemes for distributions of ellipsoids #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocalisationTensor and SphereLocalisationTensor
…ocalisationTensor
Co-authored-by: Thomas Helfer <thomas.helfer@cea.fr>
… for general ellipsoid
…ns-of-the-eshelby-tensors' into 632-tfel-material-add-computations-of-the-eshelby-tensors merging some modifs done in docs/web at the same time at those made in Eshelby.ixx
…rs' into 636-add-homogenization-schemes-for-distributions-of-ellipsoids ok
thelfer
reviewed
Nov 12, 2024
include/TFEL/Material/Eshelby.ixx
Outdated
Comment on lines
98
to
102
| assert(nu<=0.5); | ||
| assert(nu>=-1); | ||
| assert(a>LengthType{0}); | ||
| assert(b>LengthType{0}); | ||
| assert(c>LengthType{0}); |
There was a problem hiding this comment.
Please use tfel::reportContratViolation
include/TFEL/Material/Eshelby.ixx
Outdated
Comment on lines
173
to
174
| template <typename LengthType> | ||
| TFEL_HOST_DEVICE std::array<int,3> sort_ind(const LengthType& a, const LengthType& b, const LengthType& c) |
There was a problem hiding this comment.
I would suggest to hide this in a namespace internal and call it sortEllipsoidLengths or something like this
include/TFEL/Material/Eshelby.ixx
Outdated
| const auto n_2=nabc_[sig[1]]; | ||
| using namespace tfel::math; | ||
| const auto n_3=cross_product<real>(n_1,n_2); | ||
| const rotation_matrix<real> r={n_1[0],n_1[1],n_1[2],n_2[0],n_2[1],n_2[2],n_3[0],n_3[1],n_3[2]}; |
There was a problem hiding this comment.
Suggested change
| const rotation_matrix<real> r={n_1[0],n_1[1],n_1[2],n_2[0],n_2[1],n_2[2],n_3[0],n_3[1],n_3[2]}; | |
| const rotation_matrix<real> r={n_1[0],n_1[1],n_1[2], // | |
| n_2[0],n_2[1],n_2[2], // | |
| n_3[0],n_3[1],n_3[2]}; |
| * \param [in] A: mean strain localisation tensor of inclusions | ||
| */ | ||
| template <typename real, typename StressType> | ||
| TFEL_HOST_DEVICE const tfel::math::st2tost2<3u,StressType> diluteScheme( |
There was a problem hiding this comment.
Why is it limited to 3D ?
I would suggest more explicit names:
Suggested change
| TFEL_HOST_DEVICE const tfel::math::st2tost2<3u,StressType> diluteScheme( | |
| TFEL_HOST_DEVICE const tfel::math::st2tost2<3u,StressType> computeDiluteSchemeElasticStiffness( |
…eshelby-tensors ok
Co-authored-by: Thomas Helfer <thomas.helfer@cea.fr>
Co-authored-by: Thomas Helfer <thomas.helfer@cea.fr>
…tViolation messages
…rs' into 636-add-homogenization-schemes-for-distributions-of-ellipsoids ok
…c inclusions and returned isotropic moduli
…simplified things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the homogenization schemes