Update Installation, CMake, Scikit-build #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses scikit-build-core to build Python/C++ extension - Added qc- handle to cugbasis - Added automatic git submodule update - Added for sure installation to site-packages of python
- Fix classifiers - Don't need a wheel since no python files are here
- when pushed to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-requests updates the installation of cuGBasis so that it can be used within PyPI. The following changes were made:
setup.pyis removed in favour of the new setup filepyproject.tomland scikit-build-core is used as the build system.RPATHis added and the shared library and python bindings should now be added tosite-packagesgit submoduleto get the dependencies is added to CMake