-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: permissions refactor, added create permissions #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
github-actions
bot
added
enhancement
New feature or request
dbschema
graphqlschema
local-development
authorization
httpserve
graphapi
labels
Dec 3, 2024
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
matoszz
reviewed
Dec 4, 2024
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
matoszz
approved these changes
Dec 4, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
authorization
dbschema
enhancement
New feature or request
graphapi
graphqlschema
httpserve
local-development
migrations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/ent/privacy/policy/base.go
) to make writing the policies in the schemas cleaner usingWith
optionsmixins
in the schema package were all renamed to be prefixed withmixin_
to make them easier to find (they need to live in theschema
package because they have dependencies on the package itselfinternal/ent/schema/mixin_createacess.go
: adds the to/from fields for org -> group access and adds the hooks for adding tuples to fga. This currently contains a manual list of objects types, I want to follow-up later to see if these can be pulled based on annotations in the schema insteadinternal/ent/schema/mixin_grouppermissions.go
: updates to add the reverse edges to the group schema so we don't have to manually add three fields for every editor/viewer/blocked group-v
flag; removed the-v
flag from the task command that runs in CI.