Add test size option #173
Closed
Add test size option #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-thm
reviewed
Nov 19, 2024
| @@ -41,6 +42,7 @@ def pip_compile( | |||
| requirements_in = requirements_in or "//:requirements.in" | |||
| requirements_txt = requirements_txt or "//:requirements.txt" | |||
| tags = tags or [] | |||
| size = size or "small" | |||
There was a problem hiding this comment.
I think I'd like to keep this defaulted to None if unspecified, but otherwise this seems fine.
There was a problem hiding this comment.
From https://bazel.build/reference/be/common-definitions you can see the default test size to be medium which has the the spects medium 100 MB RAM 1 CPU timeout moderate (5 minutes) vs. small 20 MB RAM 1 CPU timeout short (1 minute). To me, small seems a reasonable timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test should be quite fast so should be tagged as small test to prevent test size warnings if this is enabled