Remove dependency on rules_python #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-thm
commented
May 22, 2024
| @@ -11,9 +11,6 @@ bazel_dep(name = "buildifier_prebuilt", version = "6.1.2") | |||
| bazel_dep(name = "platforms", version = "0.0.8") | |||
| bazel_dep(name = "rules_multitool", version = "0.4.0") | |||
|
|
|||
| # required for venv | |||
There was a problem hiding this comment.
not actually required for venv
rahul-theorem
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The rules_python maintainers would like to depend on rules_uv to re-publish the
pip_compilemacro, but there's some uncertainty around whether a circular dependency between rules_uv and rules_python would cause problems. rules_uv only depends on there existing a Python toolchain at execution time, and otherwise doesn't need the explicit dependency, so we can remove it.Summary
Remove the rules_python dependency from the main module and add it back in examples. Update the readme to help users continue to have a functioning ruleset.