Allow setting venv destination in rule #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-thm
reviewed
Jun 3, 2024
uv/private/venv.bzl
Outdated
| @@ -33,6 +34,7 @@ def _venv_impl(ctx): | |||
|
|
|||
| _venv = rule( | |||
| attrs = { | |||
| "destination_folder": attr.string(mandatory = True), | |||
There was a problem hiding this comment.
Let’s assign the default value here
uv/private/venv.bzl
Outdated
| @@ -42,9 +44,10 @@ _venv = rule( | |||
| executable = True, | |||
| ) | |||
|
|
|||
| def create_venv(name, requirements_txt = None, target_compatible_with = None): | |||
| def create_venv(name, requirements_txt = None, target_compatible_with = None, destination_folder = "venv"): | |||
There was a problem hiding this comment.
…and set default here for the arg to None
mark-thm
approved these changes
Jun 3, 2024
|
Thanks for the contribution and cleanup. This change will be included in a release later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could pass the directory as an argument when executing the target.
Now it is also possible to set the default destination directory in code.