-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias command implementation #36
Open
fluca1978
wants to merge
8
commits into
theory:master
Choose a base branch
from
fluca1978:alias
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 17, 2019
-
First partial implementation of the
alias
command.The idea is that this command allows the manipulation of PostgreSQL alias names, stored as links into an `/alias` directory in the `PGENV_ROOT` directory. Subcommands `add` and `remove` checks for the existance of the links and create or delete such links int he alias directory. Changes to the `versions` command in order to show also the aliases. Now, after the directory output for each version, all aliases are printed out. This changes the format of the `versions` output.
Configuration menu - View commit details
-
Copy full SHA for 7ed9fe0 - Browse repository at this point
Copy the full SHA 7ed9fe0View commit details -
Created a function to handling the versions specified as an alias.
This way a user can specify a version to use/remove as an alias, and the script will produce (normalize) the right version to use for disk layout. Added a function to remove all the aliases of a version when deleting an installation.
Configuration menu - View commit details
-
Copy full SHA for 0c977e3 - Browse repository at this point
Copy the full SHA 0c977e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8e0a6e - Browse repository at this point
Copy the full SHA f8e0a6eView commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 226a8d9 - Browse repository at this point
Copy the full SHA 226a8d9View commit details
Commits on Oct 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for baaf6b3 - Browse repository at this point
Copy the full SHA baaf6b3View commit details -
First version with aliases and multiple installations.
THIS BREAKS BACKWARD COMPATIBILITY. Now each instance is installed into a directory that includes a timestamp and is collected into a directory named by the PostgreSQL version, for instance $PGENV_ROOT/ pgsql-12.0/ pgsql-12.0-2019-10-21-14-15-35 pgsql-12.0-2019-10-21-08-36-35 pgsql-11.5/ pgsql-11.5-2019-10-20-14-15-35 pgsql-11.5-2019-10-20-08-36-35 and each instance is automatically assigned two aliases: - one with the version (12.0 for example) - one with the full timestamp (pgsql-12.0-2019-10-21-14-15-35). This means that the alias with the single PostgreSQL version (e.g., 12.0) works only for the first instance installed. All other commands have been refactored to use the alias as input. Remove sed dependency in pgenv_versions. Fix pgenv_versions to allow '*' on current instance.
Configuration menu - View commit details
-
Copy full SHA for cb71482 - Browse repository at this point
Copy the full SHA cb71482View commit details -
Refactoring of the alias commands.
The `alias remove` prevents the user to lock out removing all the aliases of an instance. The `add` command allows for alias creation.
Configuration menu - View commit details
-
Copy full SHA for 5cd650b - Browse repository at this point
Copy the full SHA 5cd650bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1321713 - Browse repository at this point
Copy the full SHA 1321713View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.