bug fix createFromComponents named constructor

thephpleague · Jan 16, 2017 · 1d0ad31 · 1d0ad31
1 parent ae5f4ec
commit 1d0ad31
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,24 @@
 
 All Notable changes to `League\Uri\Components` will be documented in this file
 
+## 1.0.1 - 2017-01-16
+
+### Added
+
+- None
+
+### Fixed
+
+- `League\Uri\Schemes\Http::createFromComponents` with invalid Host
+
+### Deprecated
+
+- None
+
+### Removed
+
+- None
+
 ## 1.0.0 - 2017-01-04
 
 ### Added

diff --git a/src/AbstractUri.php b/src/AbstractUri.php
@@ -219,6 +219,10 @@ public static function createFromComponents(array $components): self
             'port' => null, 'path' => '', 'query' => null, 'fragment' => null,
         ];
 
+        if (null !== $components['host'] && !self::getParser()->isHost($components['host'])) {
+            throw UriException::createFromInvalidHost($components['host']);
+        }
+
         return new static(
             $components['scheme'],
             $components['user'],

diff --git a/tests/UriTest.php b/tests/UriTest.php
@@ -272,6 +272,13 @@ public function testCreateFromComponents()
             Http::createFromString($uri)
         );
     }
+
+    public function testCreateFromComponentsTrowsException()
+    {
+        $this->expectException(ParserException::class);
+        Http::createFromComponents(['host' => '[127.0.0.1]']);
+    }
+
     public function testInvalidSetterThrowException()
     {
         $this->expectException(BadMethodCallException::class);