This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 5
Lots of cleanup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aramshiva
suggested changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if ESLint GIthub Action to ensure linter runs on all pull requests?
I am using commit hooks locally, that should install on clone, we can add that tho if you want. |
Signed-off-by: Jasper Mayone <jasper.mayone@singlefeather.com>
Adding Now! |
lol we both got to it :) |
aramshiva
previously approved these changes
Dec 10, 2023
lg! |
hmm some issues. gonna remove function for now. |
aramshiva
approved these changes
Dec 10, 2023
This is good to merge now yea? or.... |
yup! |
Can you approve it lol? |
It won't let me caus it's my PR -_- |
Oh you got it. I was just about to do it from here 🤷 -J |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Severe cleanup, adds linter
Description:
Related Issue:
Closes #XXXXX