Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Lots of cleanup #6

Merged
merged 8 commits into from
Dec 10, 2023
Merged

Lots of cleanup #6

merged 8 commits into from
Dec 10, 2023

Conversation

jaspermayone
Copy link
Collaborator

Pull Request

Severe cleanup, adds linter

Description:

Related Issue:

Closes #XXXXX

@jaspermayone jaspermayone requested a review from a team December 10, 2023 21:07
@jaspermayone jaspermayone self-assigned this Dec 10, 2023
@jaspermayone jaspermayone requested review from aramshiva and removed request for a team December 10, 2023 21:07
Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ❌ Failed (Inspect) Dec 10, 2023 9:29pm

Copy link
Member

@aramshiva aramshiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if ESLint GIthub Action to ensure linter runs on all pull requests?

@jaspermayone
Copy link
Collaborator Author

I am using commit hooks locally, that should install on clone, we can add that tho if you want.

aramshiva and others added 2 commits December 10, 2023 13:21
Signed-off-by: Jasper Mayone <jasper.mayone@singlefeather.com>
@aramshiva
Copy link
Member

Adding Now!

@jaspermayone
Copy link
Collaborator Author

lol we both got to it :)

aramshiva
aramshiva previously approved these changes Dec 10, 2023
@aramshiva
Copy link
Member

lg!

@aramshiva aramshiva enabled auto-merge December 10, 2023 21:27
@aramshiva aramshiva disabled auto-merge December 10, 2023 21:28
@aramshiva
Copy link
Member

hmm some issues. gonna remove function for now.

@aramshiva aramshiva requested review from a team and removed request for a team December 10, 2023 21:30
@aramshiva aramshiva requested a review from a user December 10, 2023 21:30
@jaspermayone jaspermayone removed the request for review from a user December 10, 2023 21:31
@jaspermayone
Copy link
Collaborator Author

This is good to merge now yea? or....

@aramshiva
Copy link
Member

yup!

@jaspermayone
Copy link
Collaborator Author

Can you approve it lol?

@jaspermayone
Copy link
Collaborator Author

It won't let me caus it's my PR -_-

@aramshiva aramshiva merged commit 29483af into main Dec 10, 2023
1 of 2 checks passed
@aramshiva aramshiva deleted the jasper branch December 10, 2023 21:42
@ghost
Copy link

ghost commented Dec 10, 2023

Oh you got it. I was just about to do it from here 🤷

-J

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants