sof-bytcht-da7213: initial import #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested with Minnowboard Turbot (needs MCLK) Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
RanderWang
reviewed
Oct 31, 2019
| ] | ||
|
|
||
| Value { | ||
| PlaybackChannels "2" |
There was a problem hiding this comment.
we need add something like:
PlaybackPCM "hw:sofbytchtda7213, num"
JackControl "Headphone xxx" \\ for pulse audio to detect headphoneThere was a problem hiding this comment.
@RanderWang can you check if there is a working platform with this codec in Shanghai?
I don't know if the machine driver reports the jack so it may not be really important. this is mostly a test rig.
There was a problem hiding this comment.
@plbossart I checked but didn’t find one. So we don't need to set JackControl now since we can't test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with Minnowboard Turbot (needs MCLK)
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Not sure who's got hardware to test this?