tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
aiChaoSONG
previously approved these changes
Aug 8, 2023
|
I cannot provide the link to lore as for some reason it is not picking it up |
ujfalusi
force-pushed
the
peter/sof/pr/tpm_fix_upx_i11_again
branch
from
bb3cee6
to
a4d33b6
Compare
|
Changes since v1:
|
The patch which made it to the kernel somehow changed the match condition from DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01") to DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL") Revert back to the correct match condition to disable the interrupt mode on the board. Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/ Fixes: edb13d7 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
bardliao
approved these changes
Aug 8, 2023
ujfalusi
changed the title
plbossart
approved these changes
Aug 8, 2023
| @@ -167,7 +167,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { | |||
| .ident = "UPX-TGL", | |||
| .matches = { | |||
| DMI_MATCH(DMI_SYS_VENDOR, "AAEON"), | |||
| DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"), | |||
| DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"), | |||
There was a problem hiding this comment.
well d'uh, I assumed that the upstream version was the correct one...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch which made it to the kernel somehow changed the
match condition from
DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
to
DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL")
Revert back to the correct match condition to disable the
interrupt mode on the board.
Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
Fixes: edb13d7 ("tpm: tpm_tis: Disable interrupts only for AEON UPX-i11")