ASoC: Intel: sof_rt5682: cleanup unnecessary quirk flag #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentlu
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
|
rt5650's topology cannot use 24MHz so we remove the hard-code flag in board configs. tested on CML and JSL Chromebook. |
brentlu
added
Chrome
bardliao
previously approved these changes
Aug 14, 2023
plbossart
requested changes
Aug 14, 2023
Remove SOF_RT5682_MCLK_24MHZ flag from JSL and CML/WHL board configs since the information could be retrieved from SOF API. The macro itself is removed as well. Signed-off-by: Brent Lu <brent.lu@intel.com>
plbossart
approved these changes
Aug 15, 2023
bardliao
approved these changes
Aug 16, 2023
|
Next step: Can we get codec information from somewhere instead of using quirk? |
|
I'm working on a common module for dai link creation and codec/amplifier detection which could be shared between multiple machine drivers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove SOF_RT5682_MCLK_24MHZ flag from JSL and CML board configs since the information could be retrieved from SOF API and not all JSL boards are using 24MHz mclk.