Add stub for sof_ssp_get_codec_name #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskeepax
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
bardliao
previously approved these changes
Dec 13, 2023
|
Apologies for the edit after your review, just noticed some stale function prototypes that needed removed as well, might as well add them into this pull request. |
plbossart
requested changes
Dec 18, 2023
|
Yeah apologies, not sure what I was thinking there that commit isn't upstream so shouldn't get a fixes tag. Will push a version without it shortly. |
As this function is now used in sof_board_helpers it requires a build stub for the case SSP_COMMON is not built in. Fixes: ba0c7c3 ("ASoC: Intel: board_helpers: support amp link initialization") Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Recent commits remove a lot of init functions remove their function prototypes as well. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
charleskeepax
force-pushed
the
sof/fix
branch
from
ed41cb2
to
7a64fe0
Compare
plbossart
approved these changes
Dec 19, 2023
ujfalusi
approved these changes
Dec 19, 2023
|
https://sof-ci.01.org/linuxpr/PR4746/build832/devicetest/index.html?model=TGLU_RVP_NOCODEC-ipc4&testcase=check-suspend-resume-with-playback is a known issue (thesofproject/sof#8641). Not related to this PR. Merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sof_sdw stuff wont build without ssp_common, which is not selected or required by it.
Not sure this is the preferred way to handle this, other ways might be to select SSP_COMMON from sof_sdw, or to move the whole function to somewhere more guaranteed to be built in. Also not sure if we want to return NULL, kernel should handle that fine but might be nicer to return like "unavailable" or something. But open to comments, or alternative patches.