[TEST] SoundWire: check interrupts multiple times #4976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log what the interrupt enable state is. we should merge this but there's no real merit in upstreaming this. Link: thesofproject#4943 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Log what the interrupt enable state is. we should merge this but there's no real merit in upstreaming this. Link: thesofproject#4943 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
lgirdwood,
ranj063,
kv2019i,
dbaluta,
bardliao and
ujfalusi
as code owners
plbossart
changed the title
|
wow, I did not expect the first test to report this: But I guess it makes sense for enumeration... we first see a device0, then program its device_number N so we will see another interrupt when the device reports as deviceN |
plbossart
force-pushed
the
sdw/log-interrupt-enable-disable
branch
from
069cbaa
to
c8c85f6
Compare
Test the theory that some links can report an interrupt that is lost if reported *after* the link is handled. Add a second pass to re-check all links that have not been serviced in the first pass. This filter is necessary as an interrupt will usually generate a set of commands that are handled with, d'uh, interrupts. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/log-interrupt-enable-disable
branch
from
c8c85f6
to
15bffa8
Compare
Stupid me forgot that all commands are handled with interrupts, not just peripheral state changes. we need to filter and only deal with links not handled in the first pass. |
|
not needed, interrupts are level based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a set of logs to make sure our interrupt sequences are done right on LNL
Link: #4943