SoundWire: programming flow corrections #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://sof-ci.01.org/linuxpr/PR5065/build3687/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=multiple-pipeline-playback is broken on ba-lnlm-rvp-sdw-01. I can't reproduce the problem with the same command line. works fine for me... |
|
SOFCI TEST |
3 similar comments
|
SOFCI TEST |
|
SOFCI TEST |
|
SOFCI TEST |
|
@bardliao can you review? |
Follow the recommended programming flows. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Follow recommended programming flows. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/correct-programming-flows
branch
from
18cb56a
to
96dc311
Compare
|
updated version without controversial patches. |
bardliao
approved these changes
Aug 6, 2024
ujfalusi
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardware documentation lists a number of steps that aren't followed by the Linux driver, such as a soft reset and disabling wakeups on startup. The interrupt enable is also not symmetrical with the disable.
It's not clear if these patches fix anything, but aligning with documented programming flows is in general never a bad idea.