ASoC: rt712-sdca: move component registration to the probe stage #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't do any devm_ based allocation in the io_init(), this need to happen in the probe(). FIXME: we could make this component allocation contingent on detecting a mic function ACPI. FIXME: the registers are not well handled today, the regmap lists registers which are not really supported in all platforms. The regmap needs to throw an error if those registers are accessed without existing. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
@shumingfan @bardliao I have quite a few concerns on how the RT712-VB integration was handled. |
shumingfan
reviewed
Aug 7, 2024
| &soc_sdca_dev_rt712_dmic, rt712_sdca_dmic_dai, ARRAY_SIZE(rt712_sdca_dmic_dai)); | ||
| if (ret < 0) | ||
| return ret; | ||
|
|
There was a problem hiding this comment.
@plbossart If we could detect the RT712VB (a mic function ACPI) before rt712_sdca_init, the dmic component registration would be nice to move here.
There was a problem hiding this comment.
we can, the function already exists but I can't figure out how to get the Kconfig right...
|
moved to updated PR #5128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't do any devm_ based allocation in the io_init(), this need to happen in the probe().
FIXME: we could make this component allocation contingent on detecting a mic function ACPI.
FIXME: the registers are not well handled today, the regmap lists registers which are not really supported in all platforms. The regmap needs to throw an error if those registers are accessed without existing.