Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup! soundwire: intel_auxdevice: add kernel parameter for mclk divider #5146

Closed
wants to merge 1 commit into from
Closed

fixup! soundwire: intel_auxdevice: add kernel parameter for mclk divider #5146

wants to merge 1 commit into from

Conversation

bardliao
Copy link
Collaborator

Add description of the kernel parameter in in kernel-parameters.txt as pre Vinod's suggestion.

@bardliao
fixup! soundwire: intel_auxdevice: add kernel parameter for mclk divider
b84a776 
Add description of the kernel parameter in in kernel-parameters.txt as
pre Vinod's suggestion.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart
plbossart reviewed Aug 19, 2024
View reviewed changes
Documentation/admin-guide/kernel-parameters.txt
sdw_mclk_divider=[SDW]
Specify the MCLK divider for Intel SoundWire buses in
case the BIOS does not provide the clock rate properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes no sense to me. We have tons of kernel parameters that are for developers only. We don't want to maintain or advertise them as a supported configuration interface.

@plbossart
Copy link
Member

from Documentation/admin-guide/kernel-parameters.rst

"
This document may not be entirely up to date and comprehensive. The command
"modinfo -p ${modulename}" shows a current list of all parameters of a loadable
module. Loadable modules, after being loaded into the running kernel, also
reveal their parameters in /sys/module/${modulename}/parameters/. Some of these
parameters may be changed at runtime by the command
echo -n ${value} > /sys/module/${modulename}/parameters/${parm}.
"

I think modinfo is more than enough here.

@bardliao
Copy link
Collaborator Author

Allright, let's close the PR.

@bardliao bardliao closed this Aug 19, 2024
@bardliao bardliao reopened this Oct 3, 2024
@bardliao
Copy link
Collaborator Author

bardliao commented Oct 3, 2024

Reopen as the maintainer is requesting to add document in kernel-parameters.txt

@bardliao
Copy link
Collaborator Author

bardliao commented Oct 4, 2024

submitted to upstream. Close for now

@bardliao bardliao closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbossart plbossart plbossart left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@ujfalusi ujfalusi Awaiting requested review from ujfalusi ujfalusi is a code owner

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bardliao @plbossart @lgirdwood