Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] ASoC: SOF: Intel: lnl: partial clock gating disable #5151

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] ASoC: SOF: Intel: lnl: partial clock gating disable #5151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bae8fd
ASoC: SOF: Intel: lnl: increase IPC timeout
kv2019i Aug 21, 2024
753262e
[DO NOT MERGE] ASoC: SOF: Intel: lnl: partial clock gating disable
kv2019i Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sound/soc/sof/intel/hda.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@
/*Vendor Specific Registers*/
#define SOF_HDA_VS_D0I3C 0x104A

#define SOF_HDA_VS_HfCLKCTL 0x1D10

#define SOF_HDA_VS_HfCLKCTL_ULPFBRDCGE BIT(1)

/* D0I3C Register fields */
#define SOF_HDA_VS_D0I3C_CIP BIT(0) /* Command-In-Progress */
#define SOF_HDA_VS_D0I3C_I3 BIT(2) /* D0i3 enable bit */
Expand Down
5 changes: 5 additions & 0 deletions sound/soc/sof/intel/lnl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ static int lnl_dsp_post_fw_run(struct snd_sof_dev *sdev)
}
}

dev_info(sdev->dev, "Set ULPFRBRDCGE to 0\n");
snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR,
SOF_HDA_VS_HfCLKCTL,
SOF_HDA_VS_HfCLKCTL_ULPFBRDCGE, 0);

return 0;
}

Expand Down
1 change: 1 addition & 0 deletions sound/soc/sof/intel/pci-lnl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ static const struct sof_dev_desc lnl_desc = {
.nocodec_tplg_filename = "sof-lnl-nocodec.tplg",
.ops = &sof_lnl_ops,
.ops_init = sof_lnl_ops_init,
.ipc_timeout = 5000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default is 500ms, that seems plenty for an IPC, no? Moving to a 5s timeout to deal with a suspend-resume problem means suspend-resume is already broken in the first place, regardless of the IPCs...

};

/* PCI IDs */
Expand Down
Loading