ASoC: SOF: ipc3-loader: Handle PROBE_INFO ext_manifest element #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elem type 3 is PROBE_INFO in ext_manifest, add it to the list. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…rsing Every time when the firmware is loaded we see the following printed in info level: unknown sof_ext_man header type 3 size 0x30 This is the PROBE_INFO element, which is not parsed, but it is not something that we should treat as surprise, aka unknown type. Add an empty case with a debug print to 'handle' this ext_manifest type and silence the confusing print in kernel log. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
ranj063,
lgirdwood,
plbossart,
kv2019i,
dbaluta and
bardliao
as code owners
plbossart
approved these changes
Sep 19, 2024
|
I don't know why Jenkins failed this one. I hope it's not a nasty side effect of #5182 (comment) EDIT: nope, this was CI change 207. Reverted for now. |
|
SOFCI TEST |
bardliao
approved these changes
Oct 1, 2024
lgirdwood
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
every kernel log contains the following info print:
unknown sof_ext_man header type 3 size 0x30It is true that we don't handle the PROBE_INFO (type 3), but it is not true that it is an unknown element.
Add enum entry and an empty case to 'handle' the PROBE_INFO and silence the print.