fixup! ASoC: Intel: soc-acpi-intel-lnl-match: add rt712_vb + rt1320 support #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
lgirdwood,
plbossart,
kv2019i and
dbaluta
as code owners
ujfalusi
previously approved these changes
Nov 11, 2024
| @@ -546,6 +547,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_lnl_sdw_machines[] = { | |||
| .link_mask = BIT(1) | BIT(2), | |||
| .links = lnl_sdw_rt712_vb_l2_rt1320_l1, | |||
| .drv_name = "sof_sdw", | |||
| .machine_check = snd_soc_acpi_intel_sdca_is_device_rt712_vb, | |||
There was a problem hiding this comment.
how did you missed this in #5223? ;)
There was a problem hiding this comment.
how did you missed this in #5223? ;)
There is no proper acpi table in my RVP. And I just realized that why don't I need to remove the .machine_check in my test.
There was a problem hiding this comment.
Also, the rt1320 ADR was wrong. I got a new AIOC from Realtek with the new rt1320 version today.
There was a problem hiding this comment.
Right, you know it best...
…upport We need to use snd_soc_acpi_intel_sdca_is_device_rt712_vb to check if the rt712 is vb. Also, fix the rt1320 ADR. I was testing with an old rt1320 version with class_id = 0. But, the class_id is 1 in the production version. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
fixup-rt712-vb
branch
from
4321d00
to
b37ce2d
Compare
ujfalusi
approved these changes
Nov 11, 2024
| @@ -546,6 +547,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_lnl_sdw_machines[] = { | |||
| .link_mask = BIT(1) | BIT(2), | |||
| .links = lnl_sdw_rt712_vb_l2_rt1320_l1, | |||
| .drv_name = "sof_sdw", | |||
| .machine_check = snd_soc_acpi_intel_sdca_is_device_rt712_vb, | |||
There was a problem hiding this comment.
Right, you know it best...
ranj063
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use snd_soc_acpi_intel_sdca_is_device_rt712_vb to check if the rt712 is vb.