Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make start_test() optional: part 1 #1170

Merged
merged 4 commits into from
Apr 20, 2024
Merged

make start_test() optional: part 1 #1170

merged 4 commits into from
Apr 20, 2024

Commits on Apr 18, 2024

  1. check-kmod-load-unload-after-playback: new playback_subtest() 

    Extract new playback_subtest() function to de-duplicate. Pure clean-up,
zero functional change.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    @marc-hb
    marc-hb committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fbee1d1 View commit details
    Browse the repository at this point in the history

  2. hijack.sh: extract new print_test_result_exit() function 

    Extract new print_test_result_exit() function from exit handler(). This
make it possible for some "light-weight" tests like
verify-kernel-boot-log.sh to not depend on the heavy and start_test()
and exit handler machinery.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    @marc-hb
    marc-hb committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    98971f6 View commit details
    Browse the repository at this point in the history

  3. check-kmod-load-unload-after-playback: disable logging in subtest 

    This unblocks thesofproject#1170 and allows "installing" the func_exit_handler() trap
in start_test() which will allow making start_test() optional.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    @marc-hb
    marc-hb committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    412292b View commit details
    Browse the repository at this point in the history

  4. lib.sh: install func_exit_handler() from start_test() 

    func_exit_handler() makes sense only when used with start_test()

start_test() is a "mandatory" right now because it's invoked from
lib.sh. But this is wrong because it should be possible to import lib.sh
functions without actually running anything and it's causing various
issues like sof_remove.sh depending on the firmware being loaded, see
discussion in thesofproject#1169

This commit will make it possible NOT to use start_test().

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    @marc-hb
    marc-hb committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dd906bf View commit details
    Browse the repository at this point in the history