Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly invoke start_test() in every test-case/*.sh #1187

Merged
merged 2 commits into from
May 6, 2024
Merged

Explicitly invoke start_test() in every test-case/*.sh #1187

merged 2 commits into from
May 6, 2024

Commits on May 1, 2024

  1. lib.sh: document more recent start_test() additions 

    Long overdue.

Zero code change.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    @marc-hb
    marc-hb committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8ab82ba View commit details
    Browse the repository at this point in the history

  2. Explicitly invoke start_test() in every test-case/*.sh 

    Stop unconditionally imposing start_test() to everything sourcing lib.sh

This makes it possible to source lib.sh without running anything which
can be useful for debugging.

For now this should be a no-op for all tests except two files in `tools/` which
were never really "tests" in the first place:

- tools/kmod/sof_remove.sh
- tools/sof-kernel-log-check.sh

In these, start_test() never made sense it never really run thanks the
(awkward) "is_subtest()" escape.

There are other tests where start_test() should not be invoked either,
most notably test-case/verify-kernel-boot-log.sh in order to fix
thesofproject#1112 but this is a huge
commit already; one change at a time.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    @marc-hb
    marc-hb committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a82935b View commit details
    Browse the repository at this point in the history