sof_remove.sh: make lib.sh optional #1220
Conversation
|
ACE and CAVS all green. Two totally unrelated errors in LNL and stable-v2.2 |
| else | ||
| printf '%s warning: %s not found, not sourced\n' "$0" "$libsh" | ||
| fi | ||
| } |
There was a problem hiding this comment.
I think you misunderstand what #1169 intends to do. The intend was to 'dumb' down the sof_remove.sh to be comparable with sof_insert.sh, to not check for PA, to not check for booted firmware, to do exactly what the script should do: remove the modules.
I don't think it makes much sense to have this workflow to just remove the modules when initially booted to legacy or DSPless mode:
cp ~/sof-test/tools/kmod/sof_remove.sh ~/
~/sof_remove.sh
rm ~/sof_remove.shThere was a problem hiding this comment.
I did understand.
This is software: it can be BOTH dumb and smart and this is what this PR does. Try it?
There was a problem hiding this comment.
The moved sof_remove.sh do work now.
Apparently it also works in place as well, not failing anymore if the device were booted in legacy or DSPless mode..
tools/kmod/sof_remove.sh
Outdated
| # shellcheck source=case-lib/lib.sh | ||
| source "$libsh" | ||
| else | ||
| printf '%s warning: %s not found, not sourced\n' "$0" "$libsh" |
There was a problem hiding this comment.
do we need to print this?
There was a problem hiding this comment.
Depends... would that be enough to get your approval? :-)
There was a problem hiding this comment.
Depends... would that be enough to get your approval? :-)
yes ;)
| else | ||
| printf '%s warning: %s not found, not sourced\n' "$0" "$libsh" | ||
| fi | ||
| } |
There was a problem hiding this comment.
The moved sof_remove.sh do work now.
Apparently it also works in place as well, not failing anymore if the device were booted in legacy or DSPless mode..
This makes is possible to use this file separately from sof-test, as requested in thesofproject#1169. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
MTL stopped booting in https://sof-ci.01.org/softestpr/PR1220/build662/devicetest/index.html, unrelated issue sof # 9308. Everything else is green. |
This makes is possible to use this file separately from sof-test, as requested in #1169.