Added "Kernel: ACPI" Error message to ignored string list #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernel and Boot log check test failed Due to ACPI bios error and its nothing harm to Audio functionality. Hence i added ACPI error as ignored string. Signed-off-by: harajend <hariprasad.rajendra@intel.com>
|
Can one of the admins verify this patch?
|
marc-hb
reviewed
Dec 16, 2024
There was a problem hiding this comment.
The commit title and message sound like you're ignoring all ACPI errors which would be excessive. Audio very much depends on ACPI. Fortunately, the actual code is more specific. They should align better with each other.
How do you know that "can't tag data node" can never affect audio on any device? What does that message mean?
If this error is specific to some device type, then it's better to add this line in the local configuration file of only these devices, see sof_local_extra_kernel_ignores and commit 83f5e41 (this new feature should be better advertised, maybe in this file)
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel and Boot log check test failed Due to ACPI bios error and its nothing harm to Audio functionality. Hence i added ACPI error as ignored string.