-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated check-sof-logger.sh #1245
base: main
Are you sure you want to change the base?
Conversation
Updated SOF-specific codecs since the sof* regex also lists sofprobes. Signed-off-by: harajend <hariprasad.rajendra@intel.com>
Can one of the admins verify this patch?
|
test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Are there any other possibilities besides these two? @kv2019i , @ranj063 , @bardliao can you answer?
-
The commit message must link to the corresponding bug, e.g. "Fixes issue [BUG] /proc/asound/sofprobes breaks "check-sof-logger" test #1243"
-
The commit title and message must describe the change much precisely. For instance:
check-sof-logger: remove wildcard from sof_alsa_card_found()
. The title has very little space, so don't use words like "update": every commit is an update.
See past commit message examples in the git log
.
Here are some good references, most of this applies to any open-source project so please spend some time and take a look
https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines
https://wiki.openstack.org/wiki/GitCommitMessages
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
@@ -71,7 +71,8 @@ sof_alsa_card_found() | |||
# note: assumes SOF card names to start with "sof", e.g. | |||
# - /proc/asound/sofsoundwire/id | |||
# - /proc/asound/sofhdadsp/id | |||
test -e /proc/asound/sof*/id | |||
test -e /proc/asound/sofsoundwire/id || | |||
test -e /proc/asound/sofhdadsp/id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment above does not make any sense after this change and must be removed (as shown in #1243 (comment))
Answer: it is not enough. |
Simpler and probably good enough: sof_alsa_card_found()
{
for i in /proc/asound/sof*/id; do
if test -e "$i"; then return 0; fi
done
return 1
} |
Updated SOF-specific codecs since the sof* regex also lists sofprobes.