Skip to content

Commit

Permalink
Tools: Topology2: TDFB: Remove enum controls to unbock CI
Browse files Browse the repository at this point in the history
This commit should be reverted after the issues in sof-test
are resolved. Without this change to topologies nearly
all CI steps fail.

The enum controls are currently used only by beamformer TDFB
component. Without control present the beam angle remains at
default and can't be adjusted by user.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
  • Loading branch information
singalsu committed Sep 6, 2024
1 parent db9be45 commit 0f89055
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 88 deletions.
3 changes: 0 additions & 3 deletions tools/topology/topology2/cavs-mixin-mixout-efx-hda.conf
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,6 @@ IncludeByKey.HDA_MIC_ENHANCED_CAPTURE {
mixer."1" {
name 'Analog Capture TDFB beam switch'
}
enum."1" {
name 'Analog Capture TDFB angle set enum'
}
# Tracking is disabled from this topology, causes high MCPS
#mixer."2" {
# name 'Analog Capture TDFB track switch'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,4 @@
mixer."2" {
name '$ANALOG_CAPTURE_PCM TDFB track'
}
enum."1" {
name '$ANALOG_CAPTURE_PCM TDFB angle set'
}
enum."2" {
name '$ANALOG_CAPTURE_PCM TDFB angle estimate'
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,4 @@
mixer."2" {
name '$ANALOG_PLAYBACK_PCM TDFB track'
}
enum."1" {
name '$ANALOG_PLAYBACK_PCM TDFB angle set'
}
enum."2" {
name '$ANALOG_PLAYBACK_PCM TDFB angle estimate'
}
}
70 changes: 0 additions & 70 deletions tools/topology/topology2/include/components/tdfb.conf
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# Where M is pipeline ID and N is a unique integer in the parent object.

<include/controls/mixer.conf>
<include/controls/enum.conf>

Class.Widget."tdfb" {
#
Expand Down Expand Up @@ -91,75 +90,6 @@ Class.Widget."tdfb" {
max 1
}

# Enum controls
enum."1" {
Object.Base {
channel.1 {
name "fc"
reg 3
shift 0
}
text.0 {
name "tdfb_enum_plus_minus_90_text"
!values [
"-90"
"-75"
"-60"
"-45"
"-30"
"-15"
"0"
"15"
"30"
"45"
"60"
"75"
"90"
]
}
ops.1 {
name "ctl"
info "enum"
#257 binds the mixer control to enum get/put handlers
get 257
put 257
}
}
}
enum."2" {
Object.Base {
channel.1 {
name "fc"
reg 3
shift 0
}
text.0 {
name "mytext"
!values [
"-90"
"-75"
"-60"
"-45"
"-30"
"-15"
"0"
"15"
"30"
"45"
"60"
"75"
"90"
]
}
ops.1 {
name "ctl"
info "enum"
#257 binds the mixer control to enum get/put handlers
get 257
put 257
}
}
}
}

#
Expand Down
3 changes: 0 additions & 3 deletions tools/topology/topology2/platform/intel/dmic-generic.conf
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,6 @@ IncludeByKey.PASSTHROUGH {
mixer."1" {
name 'Dmic0 Capture TDFB beam switch'
}
enum."1" {
name 'Dmic0 Capture TDFB angle set enum'
}
# Tracking is disabled from this topology, causes high MCPS
#mixer."2" {
# name 'Dmic0 Capture TDFB track switch'
Expand Down

0 comments on commit 0f89055

Please sign in to comment.