Skip to content

Commit

Permalink
Audio: Module adapter: Fix return value when no prepare operation
Browse files Browse the repository at this point in the history
The build of testbench for MTL platform simulation causes this build
fail (rebuilt-testbench -p mtl):

src/audio/module_adapter/module/generic.c:213:6:
error: variable 'ret' is used uninitialized whenever 'if'
condition is false [-Werror,-Wsometimes-uninitialized]
        if (md->ops->prepare) {
            ^~~~~~~~~~~~~~~~

src/audio/module_adapter/module/generic.c:236:9:
note: uninitialized use occurs here
        return ret;
               ^~~

Since it's a possibility to have a module without prepare()
operation, the initialize to zero is added to avoid the
return of undefined value.

Reported-by: Marc Herbert <marc.herbert@intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
  • Loading branch information
singalsu committed Dec 11, 2023
1 parent cdd1c91 commit b0eda35
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/audio/module_adapter/module/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ int module_prepare(struct processing_module *mod,
struct sof_source **sources, int num_of_sources,
struct sof_sink **sinks, int num_of_sinks)
{
int ret;
int ret = 0;
struct module_data *md = &mod->priv;
struct comp_dev *dev = mod->dev;

Expand Down

0 comments on commit b0eda35

Please sign in to comment.