Skip to content

Commit

Permalink
ipc4: Regression FIX: Do not clear sources/sinks on reset
Browse files Browse the repository at this point in the history
After #8594 been merged, sources
and sinks are now setup on .bind() and .unbind(). Previously they were
setup in .prepare(). However, there were code left in
module_adapter_reset() which clears sources and sinks arrays. That broke
some tests: modules which use source/sink API stopped working correctly
after pipeline reset.

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
  • Loading branch information
serhiy-katsyuba-intel committed Dec 20, 2023
1 parent b7dc3ba commit c6e3845
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/audio/module_adapter/module_adapter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1328,15 +1328,6 @@ int module_adapter_reset(struct comp_dev *dev)
}
}
#endif /* CONFIG_ZEPHYR_DP_SCHEDULER */
if (IS_PROCESSING_MODE_SINK_SOURCE(mod)) {
/* for both LL and DP processing */
for (i = 0; i < mod->num_of_sources; i++)
mod->sources[i] = NULL;
for (i = 0; i < mod->num_of_sinks; i++)
mod->sinks[i] = NULL;
mod->num_of_sinks = 0;
mod->num_of_sources = 0;
}

mod->total_data_consumed = 0;
mod->total_data_produced = 0;
Expand Down

0 comments on commit c6e3845

Please sign in to comment.