Skip to content

Commit

Permalink
.github/zephyr: switch to python 3.10 on windows
Browse files Browse the repository at this point in the history
Zephyr commit b3b8360f3993 ("west: runners: Add `west rtt` command
with pyocd implementation") adds some functionality to the
west commands making use of the pipe ("|") operator for
function return type hinting. As per PEP 604 [1], this operator
can be used for writing union types starting from python 3.10.
Since the SOF windows builds use python 3.8 this leads to
the CI failing.

To fix this, switch to using python 3.10. This is not a
problem for Linux CI jobs as they already use python 3.10.

The following is a snippet of a failed windows CI job
regarding this:

File "D:\a\sof\sof\workspace\zephyr\scripts/west_commands\runners\core.py",
line 780, in ZephyrBinaryRunner

    def get_rtt_address(self) -> int | None:

    TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'

[1]: https://peps.python.org/pep-0604/

Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
  • Loading branch information
LaurentiuM1234 committed Sep 12, 2024
1 parent 54ad8d1 commit e598fea
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/zephyr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.10'

- name: West install
run: pip3 install west
Expand All @@ -329,7 +329,7 @@ jobs:
uses: actions/setup-python@v5
id: cache-python
with:
python-version: '3.8'
python-version: '3.10'
cache: 'pip'
cache-dependency-path: workspace/zephyr/scripts/requirements.txt

Expand Down

0 comments on commit e598fea

Please sign in to comment.