Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions.json: set version to 2.8.99 #8523

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Nov 24, 2023

Open tree for 2.9 development now that stable-v2.8 is branched out.

Open tree for 2.9 development now that stable-v2.8 is branched out.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@lgirdwood
Copy link
Member

@wszypelt @lrudyX fyi - version bump should not be tested by CI ?

@lrudyX
Copy link

lrudyX commented Nov 27, 2023

@wszypelt @lrudyX fyi - version bump should not be tested by CI ?

There are no special tests for version bumps, but we check this on daily /weekly scopes. This is not CI blocker. Thank you for this attention.

@lgirdwood
Copy link
Member

@wszypelt @lrudyX fyi - version bump should not be tested by CI ?

There are no special tests for version bumps, but we check this on daily /weekly scopes. This is not CI blocker. Thank you for this attention.

and I assume we are good to merge ?

@lrudyX
Copy link

lrudyX commented Nov 27, 2023

@wszypelt @lrudyX fyi - version bump should not be tested by CI ?

There are no special tests for version bumps, but we check this on daily /weekly scopes. This is not CI blocker. Thank you for this attention.

and I assume we are good to merge ?

Yes, that is correct.

@lgirdwood lgirdwood merged commit 5c0f8bd into thesofproject:main Nov 27, 2023
41 of 43 checks passed
@kv2019i
Copy link
Collaborator Author

kv2019i commented Nov 27, 2023

Btw, @marc-hb , should we tag the branch points. Now the main branch doesn't have the release tags. We bake git-based versions into the binary, and now SOF main looks like

[    0.304501] <inf> init: print_version_banner: FW ABI 0x301d000 DBG ABI 0x5003000 tags SOF:v2.5-stable-branch-1754-g5c0f8bdf6aea zephyr:zephyr-v3.5.0-2238-g18cb2004d1da src hash 0xbb6732f5 (ref hash 0xbb6732f5)

... which is quite misleading. I did "v2.5-stable-branch" , but this is not a convetion we have followed systematically. Maybe we should and tag the opening up of the main branch with "2.8.99" perhaps. Thoughts?

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 27, 2023

Probably yes.

This was already discussed in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants