Commits on Nov 27, 2023

1. sof: coherent: Don't mark "struct coherent" as packed …

   On 64-bit systems (i.e: i.MX93), marking "struct coherent"
   as packed leads to compilation warnings such as:
   
   "warning: taking address of packed member of 'struct coherent'
   may result in an unaligned pointer value"
   
   This is because the "list" attribute is found at offset 36,
   which is not 8B-aligned. In contrast, 32-bit systems
   don't have this problem as the "list" attribute is found at
   offset 24 which is 4B-aligned.
   
   Since marking "struct coherent" as packed doesn't seem to
   be necessary, remove this to fix the compilation warnings.
   On 32-bit systems, 'pahole' shows no difference between
   the 'packed' and the non-'packed' cases as the fields are
   already naturally aligned at the moment.
   
   A more detailed discussion regarding this issue can be
   found here: thesofproject#8521.
   
   Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

   

   LaurentiuM1234 committed Nov 27, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c112d04
   • Browse repository at this point

   Copy the full SHA

   c112d04 View commit details

   Browse the repository at this point in the history