rimage: elf_file: Fix elf_free behavior on unopened elf file #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If more modules are provided in a command line than defined in a toml file, the program outputs an error message. It frees the module structures even though they have not been opened before. This resulted in an error when trying to close a file that was not previously open. Added a check to ensure that a file has been opened before trying to close it. Error handling in the elf_open function has been simplified. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
By oversight, the error message did not use the file name passed as a parameter to the module_write_whole_elf function. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
ArsenEloglian,
abonislawski,
kv2019i,
marcinszkudlinski,
piotrkmx,
pjdobrowolski,
tmleman and
serhiy-katsyuba-intel
softwarecki
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
pjdobrowolski
approved these changes
Nov 27, 2023
lgirdwood
approved these changes
Nov 27, 2023
serhiy-katsyuba-intel
approved these changes
Nov 27, 2023
lyakh
approved these changes
Nov 28, 2023
tmleman
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If more modules are provided in a command line than defined in a toml file, the program outputs an error message. It frees the module structures even though they have not been opened before. This resulted in an error when trying to close a file that was not previously open. Added a check to ensure that a file has been opened before trying to close it. Error handling in the elf_open function has been simplified.
Fixed a little issue introduced by oversight. The error message in
module_write_whole_elffunction did not use the file name passed as a parameter.