base_fw: add DMI_FORCE_L1_EXIT FW config (depends on Zephyr 66042) #8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkwasowi
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
plbossart
reviewed
Dec 1, 2023
kv2019i
changed the title
kv2019i
reviewed
Dec 4, 2023
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
2 times, most recently
from
5c3955d
to
25866d9
Compare
plbossart
approved these changes
Dec 8, 2023
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
2 times, most recently
from
2ebbfb3
to
8d311ef
Compare
Merged
kv2019i
requested changes
Dec 13, 2023
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
8d311ef
to
103910e
Compare
kv2019i
requested changes
Dec 14, 2023
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
2 times, most recently
from
3b52b65
to
f10fb9c
Compare
fkwasowi
requested review from
cujomalainey,
marc-hb,
ranj063 and
jxstelter
as code owners
fkwasowi
requested review from
RanderWang,
marcinszkudlinski and
pblaszko
as code owners
intel_adsp: lnl: add missing definition for lnl 28d5d23a232b69b213112e723e0a6392cbd5a47e Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
e3742d3
to
f34fc81
Compare
|
@fkwasowi The tgl/tgl-h still seems to fail, can you check: |
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
f34fc81
to
1fca404
Compare
kv2019i
approved these changes
Dec 18, 2023
src/audio/base_fw.c
Outdated
|
|
||
| if (force) { | ||
| tr_info(&basefw_comp_tr, "FW config set force dmi l0 state"); | ||
| #if defined(CONFIG_SOC_SERIES_INTEL_ACE) |
There was a problem hiding this comment.
Not sure what to return if the functionality is not available. Alternatively you could #ifdef the whole funciton body and at the end:
#if defined(CONFIG_SOC_SERIES_INTEL_ACE)
const uint32_t force = ..
...
#else
return IPC4_UNAVAILABLE;
#endif
Add new parameter for SW to force DMI L1 exit on IPC request. Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
1fca404
to
7f63e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new parameter for SW to force DMI L1 exit on IPC request.
Associated with: zephyrproject-rtos/zephyr#66042
Separating two new functions force and allow l1 to have the current state with separated functions in the power manager so that SOF can call these functions via IPC DMI_FORCE_L1_EXIT. DMA sometimes slows down and does not perform, therefore the workaround is to switch off l1. Change related to the addition of a new parameter to force DMI L1 exit on IPC request.