topology1: pipe-volume-capture.m4: Set minimum number of channels to 2 #8614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
approved these changes
Dec 12, 2023
Currently, the minimum number of channels for the capture PCM is set to the same value as the maximum number. This restricts the number of channels supported by the PCM to the maximum number. This is wrong if we want to allow arecord to work with multiple channel values. As such, follow the example of "pipe-volume-playback.m4" and introduce a new macro: LOCAL_CHANNELS_MIN. This will be set to "CHANNELS_MIN" if said macro is defined, otherwise it will be set to 2. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
iuliana-prodan
approved these changes
Dec 12, 2023
dbaluta
approved these changes
Dec 13, 2023
|
Intel CI stuck, but as this is tplg1 only, this has not relation, so I'll proceed with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the minimum number of channels for the capture PCM is set to the same value as the maximum number. This restricts the number of channels supported by the PCM to the maximum number. This is wrong if we want to allow arecord to work with multiple channel values. As such, follow the example of "pipe-volume-playback.m4" and introduce a new macro: LOCAL_CHANNELS_MIN. This will be set to "CHANNELS_MIN" if said macro is defined, otherwise it will be set to 2.