component: pipeline: Refactor direction testing in pipeline propagation #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up some cut/paste code that had spread around, replacing it with a simpler "comp_same_dir()" predicate. No behavioral changes, just refactoring. Also remove the big comment that was repeated in triplicate. It explained this as error handling (i.e. it must be broken topology from which we want to recover), but in fact cross-pipeline widget connections in modern SOF do run in opposite directions (c.f. echo cancellation, which need to look at the output stream to process microphone input, or smart amp devices that do the reverse). So just explain it as policy: we don't propagate across opposite-direction pipelines, period. Usages that need them need to manage their pipeline lifecycles manually. Signed-off-by: Andy Ross <andyross@google.com>
andyross
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
kv2019i
approved these changes
Dec 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
ranj063
approved these changes
Dec 13, 2023
|
Many git fetch failures in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8620/build13274310 which means this PR was mostly not tested. @lrudyX , @wszypelt these BTW there are a few west & git optimizations that would reduce impact and downtimes: |
btian1
approved these changes
Dec 14, 2023
abonislawski
approved these changes
Dec 15, 2023
marcinszkudlinski
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Split out from https://github.com//pull/8571 for separate review]
Clean up some cut/paste code that had spread around, replacing it with a simpler "comp_same_dir()" predicate. No behavioral changes, just refactoring.
Also remove the big comment that was repeated in triplicate. It explained this as error handling (i.e. it must be broken topology from which we want to recover), but in fact cross-pipeline widget connections in modern SOF do run in opposite directions (c.f. echo cancellation, which need to look at the output stream to process microphone input, or smart amp devices that do the reverse).
So just explain it as policy: we don't propagate across opposite-direction pipelines, period. Usages that need them need to manage their pipeline lifecycles manually.