loading module: fix native module interface register

[pjdobrowolski]

In SOF we have a two type loadable modules, IADK and native whose are sharing the same registering mechanism but for C++/C needs IADK is using adapter which translates methods for SOF needs.
Native loadable module is not using any additional adapters and returns pointer for API used in built-in modules and loadable.

[lgirdwood]

@pjdobrowolski looks like an optimization only in this PR ? Sorry, not following what the change is from current code in the commit message,

[pjdobrowolski]

That is not an optimalization but bugfix. Currently native loadable modules don't register theirs API.

[lgirdwood]

That is not an optimalization but bugfix. Currently native loadable modules don't register theirs API.

oh, ok - a bug fix then. Best to spell that out in the commit as it was not clear for me this was fixing an issue. Thanks !

[pjdobrowolski]

Ok, you're right. Changed title and commit name.

[lgirdwood]

@pjdobrowolski not sure if CI build error is related ?

ccache /home/cwd_user/zephyr-sdk-0.16.4/xtensa-intel_ace15_mtpm_zephyr-elf/bin/xtensa-intel_ace15_mtpm_zephyr-elf-gcc -DCC_OPTIMIZE_FLAGS=\"-O2\" -DKERNEL -DK_HEAP_MEM_POOL_SIZE=8192 -DXCC_TOOLS_VERSION=\"zephyr\" -D__ZEPHYR__=1 -DRELATIVE_FILE=\"../sof/zephyr/lib/cpu.c\" -I/zep_workspace/zephyr/include -I/zep_workspace/build-mtl/zephyr/include/generated -I/zep_workspace/zephyr/soc/xtensa/intel_adsp/ace -I/zep_workspace/zephyr/soc/xtensa/intel_adsp/common/include -I/zep_workspace/zephyr/soc/xtensa/intel_adsp/ace/include -I/zep_workspace/zephyr/soc/xtensa/intel_adsp/ace/include/intel_ace15_mtpm -I/zep_workspace/zephyr/drivers -I/zep_workspace/sof/zephyr/include -I/zep_workspace/sof/src/platform/intel/ace/include -I/zep_workspace/sof/src/platform/meteorlake/include -I/zep_workspace/sof/src/include/sof/audio/module_adapter/iadk -I/zep_workspace/sof/src/include/sof/audio/module_adapter/library -I/zep_workspace/modules/hal/xtensa/include -I/zep_workspace/modules/hal/xtensa/XTENSA_HAL -I/zep_workspace/modules/hal/xtensa/zephyr/soc/intel_ace15_mtpm -I/zep_workspace/sof/tools/rimage/src/include -I/zep_workspace/sof/src/include -I/zep_workspace/sof/src/arch/xtensa/include -I/zep_workspace/sof/third_party/include -I/zep_workspace/sof/xtos/include -isystem /zep_workspace/zephyr/lib/libc/minimal/include -isystem /zep_workspace/zephyr/lib/libc/common/include -isystem /opt/toolchains/zephyr-sdk-0.16.4/xtensa-intel_ace15_mtpm_zephyr-elf/bin/../lib/gcc/xtensa-intel_ace15_mtpm_zephyr-elf/12.2.0/include -isystem /opt/toolchains/zephyr-sdk-0.16.4/xtensa-intel_ace15_mtpm_zephyr-elf/bin/../lib/gcc/xtensa-intel_ace15_mtpm_zephyr-elf/12.2.0/include-fixed -fno-strict-aliasing -O2 -imacros /zep_workspace/build-mtl/zephyr/include/generated/autoconf.h -ffreestanding -fno-common -g -gdwarf-4 -fdiagnostics-color=always --sysroot=/home/cwd_user/zephyr-sdk-0.16.4/xtensa-intel_ace15_mtpm_zephyr-elf/xtensa-intel_ace15_mtpm_zephyr-elf -imacros /zep_workspace/zephyr/include/zephyr/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -Werror -fno-asynchronous-unwind-tables -fstrict-overflow -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/zep_workspace/sof/app=CMAKE_SOURCE_DIR -fmacro-prefix-map=/zep_workspace/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/zep_workspace=WEST_TOPDIR -ffunction-sections -fdata-sections -mlongcalls -DXTENSA_TOOLCHAIN_VARIANT=1 -std=c99 -nostdinc -std=gnu99 -MD -MT modules/sof/CMakeFiles/modules_sof.dir/lib/cpu.c.obj -MF modules/sof/CMakeFiles/modules_sof.dir/lib/cpu.c.obj.d -o modules/sof/CMakeFiles/modules_sof.dir/lib/cpu.c.obj -c /zep_workspace/sof/zephyr/lib/cpu.c
/zep_workspace/sof/zephyr/lib/cpu.c: In function 'secondary_init':
/zep_workspace/sof/zephyr/lib/cpu.c:47:9: error: implicit declaration of function 'z_smp_thread_init'; did you mean 'smp_timer_init'? [-Werror=implicit-function-declaration]
   47 |         z_smp_thread_init(arg, &dummy_thread);
      |         ^~~~~~~~~~~~~~~~~
      |         smp_timer_init
/zep_workspace/sof/zephyr/lib/cpu.c:58:9: error: implicit declaration of function 'z_smp_thread_swap'; did you mean 'z_impl_k_thread_start'? [-Werror=implicit-function-declaration]
   58 |         z_smp_thread_swap();
      |         ^~~~~~~~~~~~~~~~~
      |         z_impl_k_thread_start
/zep_workspace/sof/zephyr/lib/cpu.c: In function 'cpu_enable_core':
/zep_workspace/sof/zephyr/lib/cpu.c:152:17: error: implicit declaration of function 'z_init_cpu' [-Werror=implicit-function-declaration]
  152 |                 z_init_cpu(id);
      |                 ^~~~~~~~~~
cc1: all warnings being treated as errors
[232/400] Building C object modules/sof/CMakeFiles/modules_sof.dir/zep_workspace/sof/src/audio/eq_fir/eq_fir_hifi2ep.c.obj

[marc-hb]

Failures to compile with the Zephyr main branch are known and unrelated:
https://github.com/thesofproject/sof/actions/runs/7562861040/job/20594168710?pr=8754

implicit declaration of function 'z_smp_thread_init';

They're caused by backwards-incompatible change:

• kernel: introduce k_smp_cpu_start() and k_smp_cpu_resume() zephyrproject-rtos/zephyr#64755