lib_manager: Set target memory flags after data loading from storage #8882
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
abonislawski,
marcinszkudlinski,
jxstelter,
pjdobrowolski and
tmleman
softwarecki
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
softwarecki
force-pushed
the
rwx
branch
2 times, most recently
from
98b6361
to
b200a01
Compare
jxstelter
approved these changes
Feb 26, 2024
lgirdwood
approved these changes
Feb 26, 2024
|
@softwarecki I think this and others are blocked by the Zephyr upgrade. We should be able to fix this soon though. |
marcinszkudlinski
approved these changes
Feb 27, 2024
lyakh
reviewed
Feb 28, 2024
|
SOFCI TEST |
lyakh
approved these changes
Feb 29, 2024
lgirdwood
added
the
blocked
|
@softwarecki will mark this as blocked on Zephyr update (impacts other PRs too). @lyakh now looking at resolving Zephyr update. |
|
@softwarecki Zephyr is now updated, so this is unblocked now (but you do need to rebase). |
|
@softwarecki could you update this one, please? |
|
@softwarecki This adds a sparse warnings: can you check? |
Memory region must first be mapped as writable to allow data to be placed there. Then the target access flags are set, e.g. read-only and executable. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
tmleman
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory region must first be mapped as writable to allow data to be placed there. Then the target access flags are set, e.g. read-only and executable.
Updated zephyr to zephyrproject-rtos/zephyr@9cf3e08