Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idc: zephyr: remove unnecessary cache invd/flush calls #8910

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Mar 6, 2024

The IDC message objects are stored to static "idc_work", so the cache operations are unnecessary when pointers to these messages are passed around.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 6, 2024

Subset of #8753 that was never merged. This commit is part of the Intel mtl-008-drop-stable branch.

@kv2019i kv2019i force-pushed the 202403-idc-remove-cache-flushes branch from d37a067 to 0197563 Compare March 13, 2024 08:43
The IDC message objects are stored to static "idc_work", so
the cache operations are unnecessary when pointers to these
messages are passed around.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202403-idc-remove-cache-flushes branch from 0197563 to f653059 Compare March 20, 2024 18:53
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 21, 2024

The github workflows are showing unexpected and seemingly unrelated errors like https://github.com/thesofproject/sof/actions/runs/8364378155/job/22899572439?pr=8910 , https://github.com/thesofproject/sof/actions/runs/8364378158/job/22899572976?pr=8910 and https://github.com/thesofproject/sof/actions/runs/8364378161/job/22899572338?pr=8910.

@marc-hb @fredoh9 safe to ignore...?

@ssavati https://sof-ci.01.org/sofpr/PR8910/build3558/devicetest/index.html is showing one error, but seems like a DUT configuration issue. I assume safe to ignore if other tests pass?

Rest looks good.

@ssavati
Copy link

ssavati commented Mar 21, 2024

The github workflows are showing unexpected and seemingly unrelated errors like https://github.com/thesofproject/sof/actions/runs/8364378155/job/22899572439?pr=8910 , https://github.com/thesofproject/sof/actions/runs/8364378158/job/22899572976?pr=8910 and https://github.com/thesofproject/sof/actions/runs/8364378161/job/22899572338?pr=8910.

@marc-hb @fredoh9 safe to ignore...?

@ssavati https://sof-ci.01.org/sofpr/PR8910/build3558/devicetest/index.html is showing one error, but seems like a DUT configuration issue. I assume safe to ignore if other tests pass?

Rest looks good.

@kv2019i Yes please ignore this. The device BIOS setting reset happened so audio devices are not enumerated. Now I fixed the issue with the device. Let me re-genrate result for you.

@kv2019i Re-run results are here and all PASS now
https://sof-ci.ostc.intel.com/#/result/planresultdetail/39048
https://sof-jenkins.ostc.intel.com/job/generic_test_new/5365/

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 21, 2024

Wow, this IMX build failure is very strange; the same build passed on Linux!
cc: @dbaluta

Re-running it just to see...

https://github.com/thesofproject/sof/actions/runs/8364378166/job/22899576265?pr=8910

D:/a/sof/sof/workspace/zephyr/drivers/interrupt_controller/intc_nxp_irqsteer.c:227:10: fatal error: fsl_irqsteer.h: No such file or directory
  227 | #include <fsl_irqsteer.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.

EDIT: re-run passed in https://github.com/thesofproject/sof/actions/runs/8364378166/job/22945044452?pr=8910

We'll never know.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 21, 2024

Fuzzing failed in
https://github.com/thesofproject/sof/actions/runs/8364378158/job/22899572976?pr=8910
with some obscure 32 bits package dependency issue. "Current runner version: '2.314.1'"

A more recent run passed fuzzing in
https://github.com/thesofproject/sof/actions/runs/8378366463/job/22942745181?pr=8974 with the same runner version... this PR is cursed!

Same mysterious 32bits package dependency failure in stub-builds
https://github.com/thesofproject/sof/actions/runs/8364378161/job/22899572338?pr=8910

Re-running them too.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 21, 2024

Re-run results are here and all PASS now

@ssavati please use the magic words SOFCI TEST (alone in a new comment) for a full re-run that also publishes results.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 21, 2024

SOFCI TEST

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 21, 2024

one ACE device failed to load the firmware - all tests failed
https://sof-ci.01.org/sofpr/PR8910/build3598/devicetest/index.html

These logs are not visible because of:

I used ssh to fetch them

Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_sof:sof_control_load: sof-audio-pci-intel-mtl 0000:00:1f.3: tplg: load control type 1 name : Amplifier Volume
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_sof:sof_control_load_volume: sof-audio-pci-intel-mtl 0000:00:1f.3: tplg: load kcontrol index 18 chans 2
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_sof:sof_widget_ready: sof-audio-pci-intel-mtl 0000:00:1f.3: tplg: widget 18 (gain.20.1) is ready [type: 6, pipe: 20, pins: 1 / 1, stream: none]
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_sof:sof_widget_ready: sof-audio-pci-intel-mtl 0000:00:1f.3: tplg: widget 19 (mixin.20.1) is ready [type: 4, pipe: 20, pins: 1 / 3, stream: none]
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_sof:sof_widget_ready: sof-audio-pci-intel-mtl 0000:00:1f.3: tplg: widget 20 (pipeline.20) is ready [type: 32, pipe: 20, pins: 0 / 0, stream: none]
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_sof:sof_widget_ready: sof-audio-pci-intel-mtl 0000:00:1f.3: tplg: widget 21 (alh-copier.SDW2-Playback.0) is ready [type: 27, pipe: 21, pins: 1 / 0, stream>
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof-audio-pci-intel-mtl 0000:00:1f.3: error: can't connect DAI alh-copier.SDW2-Playback.0 stream SDW2-Playback
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : alh-copier.SDW2-Playback.0 stream SDW2-Playback
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof_sdw sof_sdw: ASoC: failed to load widget alh-copier.SDW2-Playback.0
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof_sdw sof_sdw: ASoC: topology: could not load header: -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof-audio-pci-intel-mtl 0000:00:1f.3: error: tplg component load failed -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed to load DSP topology -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof_sdw sof_sdw: ASoC: failed to instantiate card -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: sof_sdw: probe of sof_sdw failed with error -22
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_soc_rt711_sdca:rt711_sdca_calibration: rt711-sdca sdw:0:0:025d:0711:01: rt711_sdca_calibration calibration complete, ret=0
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: snd_soc_rt711_sdca:rt711_sdca_io_init: rt711-sdca sdw:0:0:025d:0711:01: rt711_sdca_io_init hw_init complete
Mar 21 17:34:29 sh-mtlp-rvp-sdw-03 kernel: soundwire_bus:sdw_handle_slave_status: rt711-sdca sdw:0:0:025d:0711:01: signaling initialization completion for Slave 6

@kv2019i kv2019i merged commit 6f7aee8 into thesofproject:main Mar 22, 2024
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants