-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idc: zephyr: remove unnecessary cache invd/flush calls #8910
idc: zephyr: remove unnecessary cache invd/flush calls #8910
Conversation
Subset of #8753 that was never merged. This commit is part of the Intel mtl-008-drop-stable branch. |
d37a067
to
0197563
Compare
The IDC message objects are stored to static "idc_work", so the cache operations are unnecessary when pointers to these messages are passed around. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
0197563
to
f653059
Compare
The github workflows are showing unexpected and seemingly unrelated errors like https://github.com/thesofproject/sof/actions/runs/8364378155/job/22899572439?pr=8910 , https://github.com/thesofproject/sof/actions/runs/8364378158/job/22899572976?pr=8910 and https://github.com/thesofproject/sof/actions/runs/8364378161/job/22899572338?pr=8910. @marc-hb @fredoh9 safe to ignore...? @ssavati https://sof-ci.01.org/sofpr/PR8910/build3558/devicetest/index.html is showing one error, but seems like a DUT configuration issue. I assume safe to ignore if other tests pass? Rest looks good. |
@kv2019i Yes please ignore this. The device BIOS setting reset happened so audio devices are not enumerated. Now I fixed the issue with the device. Let me re-genrate result for you. @kv2019i Re-run results are here and all PASS now |
Wow, this IMX build failure is very strange; the same build passed on Linux! Re-running it just to see... https://github.com/thesofproject/sof/actions/runs/8364378166/job/22899576265?pr=8910
EDIT: re-run passed in https://github.com/thesofproject/sof/actions/runs/8364378166/job/22945044452?pr=8910 We'll never know. |
Fuzzing failed in A more recent run passed fuzzing in Same mysterious 32bits package dependency failure in stub-builds Re-running them too. |
@ssavati please use the magic words SOFCI TEST (alone in a new comment) for a full re-run that also publishes results. |
SOFCI TEST |
one ACE device failed to load the firmware - all tests failed These logs are not visible because of: I used ssh to fetch them
|
The IDC message objects are stored to static "idc_work", so the cache operations are unnecessary when pointers to these messages are passed around.