[stable-v2.9] Tools: Topology2: Add IIR, FIR, DRC to HDA analog playback #8943
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces pipeline mixout-gain-dai-copier-playback with mixout-gain-efx-dai-copier-playback. The purpose is to allow enhance of audio playback quality with equalizers (IIR and FIR) and dynamic range control (DRC). The components are programmed by default to passthrough for minimal overhead. They can be activated via sof-ctl or UCM with ALSA controls. - Post Mixer Analog Playback IIR Eq bytes - Post Mixer Analog Playback FIR Eq bytes - Post Mixer Analog Playback DRC bytes - Post Mixer Analog Playback DRC switch The recommendation is to keep headphone playback flat and enable processing only when HDA output is in speaker mode. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
kv2019i
changed the title
|
@kv2019i The CI Jenkins fails look to me unrelated with this patch. |
plbossart
requested changes
Mar 14, 2024
| @@ -28,7 +31,7 @@ Object.Dai.HDA [ | |||
| ] | |||
|
|
|||
| Object.Pipeline { | |||
| mixout-gain-dai-copier-playback [ | |||
| mixout-gain-efx-dai-copier-playback [ | |||
There was a problem hiding this comment.
Sorry, I think it's the wrong way of proceeding. I talked to @ranj063 on this many months ago and what we need is a way to have nested pipelines, where additional elements are added to a baseline.
So the baseline is mixout-dai-copier, and we should be able to add gain, eq, drc, 3rd party with extensions rather than the creation of a new pipeline all the time.
Let's not add this by default, we will pay it dearly when we want to trim down the firmware for performance or early FPGA work with limited resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces pipeline mixout-gain-dai-copier-playback with mixout-gain-efx-dai-copier-playback. The purpose is to allow enhance of audio playback quality with equalizers (IIR and FIR) and dynamic range control (DRC).
The components are programmed by default to passthrough for minimal overhead. They can be activated via sof-ctl or UCM with ALSA controls.
The recommendation is to keep headphone playback flat and enable processing only when HDA output is in speaker mode.