audio: dai-zephyr: convert DMA src/dst addresses to host-relative addresses #8948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentiuM1234
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
| @@ -751,8 +751,17 @@ static int dai_set_dma_config(struct dai_data *dd, struct comp_dev *dev) | |||
| for (i = 0; i < dma_cfg->block_count; i++) { | |||
| dma_block_cfg->dest_scatter_en = config->scatter; | |||
| dma_block_cfg->block_size = config->elem_array.elems[i].size; | |||
| dma_block_cfg->source_address = config->elem_array.elems[i].src; | |||
| dma_block_cfg->dest_address = config->elem_array.elems[i].dest; | |||
| if (dev->direction == SOF_IPC_STREAM_PLAYBACK) { | |||
There was a problem hiding this comment.
Why add a new if based on direction?
You can use the one below, from line 765.
There was a problem hiding this comment.
my bad, fixed!
LaurentiuM1234
force-pushed
the
dma_src_dest_patch
branch
from
cdb9394
to
de3f581
Compare
…resses The DMAC has the same view of the address space as the HOST. As such, the source and destination addresses need to be converted to HOST-relative addresses before attempting to perform a DMA transfer. This is only relevant for platforms for which the DSP and HOST have different views of the address space (e.g: i.MX8ULP). Also, if a platform doesn't define the `local_to_host` macro (used for converting DSP local address to HOST-relative address) we assume that the HOST and the DSP have the same view of the address space. As such, we also add a definition of `local_to_host` which will just return the passed address. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
dbaluta
approved these changes
Mar 15, 2024
iuliana-prodan
approved these changes
Mar 15, 2024
kv2019i
approved these changes
Mar 15, 2024
|
@wszypelt Can you check? Job 13725213 was cancelled and exceptation is this PR is a no-op for Intel platforms. |
|
@kv2019i Internal Intel CI System - all green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DMAC has the same view of the address space as the HOST. As such, the source and destination addresses need to be converted to HOST-relative addresses before attempting to perform a DMA transfer. This is only relevant for platforms for which the DSP and HOST have different views of the address space (e.g: i.MX8ULP).