Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Tools: Topology2: Add IIR, FIR, DRC to HDA analog playback" #8962

Closed
wants to merge 1 commit into from

Conversation

fredoh9
Copy link
Contributor

@fredoh9 fredoh9 commented Mar 18, 2024

This is reverting SOF PR8934.
#8934

This reverts commit 727ad82.

@singalsu
Copy link
Collaborator

@fredoh9 Can you try this instead. LNL platform is no more enabling components in app/boards/intel_adsp_ace20_lnl.conf

diff --git a/src/audio/drc/Kconfig b/src/audio/drc/Kconfig
index 9e6aaf638..90295bb1e 100644
--- a/src/audio/drc/Kconfig
+++ b/src/audio/drc/Kconfig
@@ -9,7 +9,7 @@ config COMP_DRC
        select NUMBERS_NORM
        select MATH_EXP
        select COMP_BLOB
-       default n
+       default y
        help
          Select for Dynamic Range Compressor (DRC) component. A DRC can be used
          to reduce the volume of loud sounds and amplify silent sounds thus

Another way would be to add there for DRC and others

CONFIG_COMP_DRC=y

@lrgirdwo @kv2019i Which approach would you recommend?

@@ -7,9 +7,6 @@ Define {
DEEP_BUFFER_PIPELINE_SRC 'mixin.15.1'
DEEP_BUFFER_PIPELINE_SINK 'mixout.2.1'
DEEP_BUFFER_PCM_NAME 'Deepbuffer HDA Analog'
EFX_FIR_PARAMS 'passthrough'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another fix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #8963

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add my +1 one to this as well. I'd prefer #8963 , but we should get one of these merged ASAP.

@kv2019i
Copy link
Collaborator

kv2019i commented Mar 20, 2024

#8963 merged, @fredoh9 please close this one if the tests are good with main.

@fredoh9
Copy link
Contributor Author

fredoh9 commented Mar 20, 2024

Today's daily test looks good.

@fredoh9 fredoh9 closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants