Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App: Boards: Set CONFIG_COMP_DRC=y for LNL platform #8963

Merged
merged 1 commit into from
Mar 19, 2024
Merged

App: Boards: Set CONFIG_COMP_DRC=y for LNL platform #8963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/boards/intel_adsp_ace20_lnl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ CONFIG_LUNARLAKE=y
CONFIG_IPC_MAJOR_4=y

CONFIG_COMP_SRC=y

CONFIG_COMP_SRC_IPC4_FULL_MATRIX=y
CONFIG_COMP_DRC=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively should this be a library @singalsu ?

I thought this was the direction of travel for all processing components?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to do it and if it's in usable state, I saw there were problems with IIR as test. This is a fix for new platform failure #8961, so if this works I'd prefer a quick merge and improve to library later. Also better to experiment new things in mature platform like MTL.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart we are not there yet @lyakh correct me if I'm wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't @lgirdwood say that we would only test volume as separate components though? Maybe I am confused on timelines, but do we agree that at some point all those processing should come as libraries?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart you mean as loadable libraries / modules? @kv2019i is right - in principle it's all there and working, there are just a couple of "temporary minor issues," e.g. ATM it's only working with open-source toolchains like the Zephyr one, not with the Cadence Xplorer based one...

Copy link
Member

@plbossart plbossart Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm, then the stated goal of testing volume components only as libraries is not realistic until all dependencies are handled. Clearly the use of the Cadence toolchain is a key requirement, we don't release anything based on open-source toolchains.


# power settings
CONFIG_PM=y
Expand Down
Loading