Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: boards: Enable Probe for LNL #8982

Merged
merged 1 commit into from
Apr 2, 2024
Merged

app: boards: Enable Probe for LNL #8982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/boards/intel_adsp_ace20_lnl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ CONFIG_WINSTREAM_CONSOLE=n

CONFIG_INTEL_ADSP_IPC=y

CONFIG_PROBE=y
Copy link
Member

@plbossart plbossart Mar 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config PROBE
bool "Probes enabled"
default y if CAVS

Should this be CAVS | ACE so that all platforms have this by default?

config PROBE_DMA_MAX
int "Maximum injection probe DMAs attached"

The name of the Kconfig is very misleading, consider renaming to make it self-explanatory that this is for INJECTION only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these handled in separate PRs. Especially with vendor defaults, I wonder if it would be better to have some common definition files e.g. for Intel SOF platforms. The PROBE is really a generic feature not tied to hardware in anyway, so having the defaults set based on HW capabilities is a bit misleading. This is really about which feature Intel SOF builds want to have enabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit title: boards

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, the commit still has the typo (updating the pull request title won't change the commit).

CONFIG_PROBE_DMA_MAX=2

# Temporary disabled options
CONFIG_TRACE=n
Expand Down
Loading