-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: Test zephyr pr affecting SoF #8998
Conversation
Test Zephyr #70394 pr on SoF CI. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
DO NOT MERGE :) |
Can one of the admins verify this patch?
|
test this please |
@marc-hb I think this highlights a practical problem in running Zephyr PRs through SOF is that the CI results are not so easy to parse at the moment. IOW you need SOF maintainer help. It's still a net win to have this PR from SOF point of view, so I' glad to help parse the reports, but I worry how this scales to something that can be done by "any Zephyr developer". @ceolin The on-device results in "sof-ci/jenkins" look good. There are failures but this are known issues in CI infra now. I have no idea why the "Internal Intel CI" have not reported anything back. @wszypelt ? |
Yes our validation has issues. I hope the answer is not less validation. |
@kv2019i The issue needs to be investigated. Now I have manually queued the build and tests, the results should be available within 40 minutes |
Agreed 200%: it's still a huge win compared to trying to bisecting and debugging a Zephyr change that was merged (and... forgotten) 2 or 3 weeks ago. With a couple other, unrelated regressions on top.
This does not have to scale to "any Zephyr developer" but only to any developer who makes Audio DSP changes in Zephyr. 90% of these are also SOF developers anyway, so it's only the matter of helping the 10% left (e.g.: @ceolin) with decyphering failures. It would be great to have too many developers and an actual scalability issue. Let's talk again if/when we get there. Of course it's also the matter of having fewer failures in the first place - but which sane developer would not want that anyway in 2024? https://www.martinfowler.com/articles/continuousIntegration.html#FixBrokenBuildsImmediately (2000) |
Thank you folks ! The original pr was merged. Closing this one. |
Test Zephyr #70394 pr on SoF CI.