[STABLE-2.2] dma-trace.c: lower log level of dropped logs and stop the recursion #9036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
marc-hb
force-pushed
the
drop-trace-warn22
branch
from
ce63729
to
4baa64c
Compare
marc-hb
changed the title
kv2019i
reviewed
Apr 25, 2024
|
Why not, will do. I submitted to stable-v2.2 first because we don't test this code in the main branch. |
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Apr 25, 2024
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood
pushed a commit
that referenced
this pull request
Apr 30, 2024
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see #9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com> (cherry picked from commit bb31696)
marc-hb
force-pushed
the
drop-trace-warn22
branch
from
4baa64c
to
091aa22
Compare
Done. All tests passed with cherry-picked commit in https://sof-ci.01.org/sofpr/PR9036/build4408/devicetest/index.html |
lgirdwood
approved these changes
May 1, 2024
kv2019i
approved these changes
May 2, 2024
eddy1021
pushed a commit
to eddy1021/sof
that referenced
this pull request
Jul 15, 2024
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping logs is bad but it should not be fatal in itself.
This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)
Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.
Disclaimer: this was (successfully) tested only on stable-v2.2, see #9036
Signed-off-by: Marc Herbert marc.herbert@intel.com
(cherry picked from commit marc-hb@bb31696)