-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STABLE-2.2] dma-trace.c: lower log level of dropped logs and stop the recursion #9036
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ce63729
to
4baa64c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, can we have this is main as well? And if it's there, can we cherry-pick with -x ?
Why not, will do. I submitted to stable-v2.2 first because we don't test this code in the main branch. |
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see #9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com> (cherry picked from commit bb31696)
4baa64c
to
091aa22
Compare
Done. All tests passed with cherry-picked commit in https://sof-ci.01.org/sofpr/PR9036/build4408/devicetest/index.html |
Dropping logs is bad but it should not be fatal in itself. This ERROR is one of the last remaining errors in stable-v2.2, see thesofproject/sof-test#1075 (comment) Also switch to the "etrace": drop the dubious recursion and stop using the DMA trace when it's already saturated. Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Dropping logs is bad but it should not be fatal in itself.
This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)
Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.
Disclaimer: this was (successfully) tested only on stable-v2.2, see #9036
Signed-off-by: Marc Herbert marc.herbert@intel.com
(cherry picked from commit marc-hb@bb31696)