Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STABLE-2.2] dma-trace.c: lower log level of dropped logs and stop the recursion #9036

Merged
merged 1 commit into from
May 2, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 11, 2024

Dropping logs is bad but it should not be fatal in itself.

This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)

Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.

Disclaimer: this was (successfully) tested only on stable-v2.2, see #9036

Signed-off-by: Marc Herbert marc.herbert@intel.com
(cherry picked from commit marc-hb@bb31696)

@marc-hb marc-hb changed the title dma-trace.c: lower log level of dropped logs [STABLE-2.2] dma-trace.c: lower log level of dropped logs Apr 11, 2024
@marc-hb

This comment was marked as outdated.

@marc-hb

This comment was marked as outdated.

@marc-hb

This comment was marked as outdated.

@marc-hb marc-hb changed the title [STABLE-2.2] dma-trace.c: lower log level of dropped logs [STABLE-2.2] dma-trace.c: lower log level of dropped logs and stop the recursion Apr 24, 2024
@marc-hb marc-hb marked this pull request as ready for review April 24, 2024 23:31
@marc-hb marc-hb requested a review from akloniex as a code owner April 24, 2024 23:31
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can we have this is main as well? And if it's there, can we cherry-pick with -x ?

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 25, 2024

Why not, will do. I submitted to stable-v2.2 first because we don't test this code in the main branch.

@marc-hb marc-hb marked this pull request as draft April 25, 2024 14:10
marc-hb added a commit to marc-hb/sof that referenced this pull request Apr 25, 2024
Dropping logs is bad but it should not be fatal in itself.

This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)

Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.

Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood pushed a commit that referenced this pull request Apr 30, 2024
Dropping logs is bad but it should not be fatal in itself.

This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)

Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.

Disclaimer: this was (successfully) tested only on stable-v2.2, see #9036

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Dropping logs is bad but it should not be fatal in itself.

This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)

Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.

Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
(cherry picked from commit bb31696)
@marc-hb marc-hb marked this pull request as ready for review April 30, 2024 18:53
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 30, 2024

Hmm, can we have this is main as well? And if it's there, can we cherry-pick with -x ?

Done.

All tests passed with cherry-picked commit in https://sof-ci.01.org/sofpr/PR9036/build4408/devicetest/index.html

@kv2019i kv2019i merged commit 7b46ae6 into thesofproject:stable-v2.2 May 2, 2024
21 of 22 checks passed
@marc-hb marc-hb deleted the drop-trace-warn22 branch May 3, 2024 21:40
eddy1021 pushed a commit to eddy1021/sof that referenced this pull request Jul 15, 2024
Dropping logs is bad but it should not be fatal in itself.

This ERROR is one of the last remaining errors in stable-v2.2, see
thesofproject/sof-test#1075 (comment)

Also switch to the "etrace": drop the dubious recursion and stop using
the DMA trace when it's already saturated.

Disclaimer: this was (successfully) tested only on stable-v2.2, see thesofproject#9036

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants