audio: base_fw: move platform specific code from base_fw.c #9060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
force-pushed
the
202404-basefw-getset-platform-impl
branch
from
40572a6
to
1faa2a1
Compare
kv2019i
requested review from
RanderWang,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
|
Fuzzing fails to apt get problem -> https://github.com/thesofproject/sof/actions/runs/8739094489/job/23979620908?pr=9060 Checkpatch fail is from existing code I'm moving around -> https://github.com/thesofproject/sof/actions/runs/8739094514/job/23979621326?pr=9060 |
|
@abonislawski @softwarecki @tmleman @tobonex can you take a look? |
lgirdwood
approved these changes
Apr 22, 2024
|
@lgirdwood wrote:
I thought we concluded on this already, this is essentially one of the options I proposed in #9012 (comment) (but not the one that was merged). Oh well, I can make a follow-up PR that folds the Intel specific code and drops the platform abstractions. |
Fix spelling in platform_basefw_hw_config() documentation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Some of the IPC4 FW_CONFIG fields are platform specific and cannot be filled with generic code. Handle this data by adding a call to platform_basefw_fw_config() and add an implementation for all current platforms with IPC4 support. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add support to handle platform specific extensions with platform_basefw_get_large_config() and platform_basefw_set_large_config(). These functions are called when get/set handled is called with a parameter type not handled in generic code. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move the Intel specific L1_EXIT control handling from base_fw.c to Intel specific platform code. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
The implementation for IPC4_MEMORY_STATE_INFO_GET requires reading direct register contents to fill out the structure, so this is by definition platform specific code. Move this to platform implementation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move implementation of IPC4_EXTENDED_SYSTEM_TIME from generic to platform specific code. The implementation depends on specific ART counter that is not available on all platforms, so it is better to handle this in platform specific code. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add missing copyright statement to file header. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202404-basefw-getset-platform-impl
branch
from
1faa2a1
to
09bf0bc
Compare
|
V2:
|
This was referenced Apr 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue from #9059 (first 2 patches here are from #9059) and move more implementation out from the generic file.
UPDATE: 9059 closed, let's review the whole set in one go.
Addressing #8391 and #7549