Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dp: make dp_queue using externally provided params set #9063

Merged
merged 2 commits into from
Apr 25, 2024
Merged

dp: make dp_queue using externally provided params set #9063

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
481b328
dp: remove dead code from dp_queue
marcinszkudlinski Apr 19, 2024
aa07558
dp: make dp_queue using externally provided params set
marcinszkudlinski Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/include/sof/audio/dp_queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,18 +176,6 @@ struct sof_source *dp_queue_get_source(struct dp_queue *dp_queue)
return &dp_queue->_source_api;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to avoid unncessary concerns, I'd avoid use of word "backdoor". Somehow a github commit to "add a backdoor" can raise unwanted attention. "Side interface" perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you see this code is removed by this commit ;)

}

/**
* @brief this is a backdoor to get complete audio params structure from dp_queue
* it is needed till pipeline 2.0 is ready
*
*/
static inline
struct sof_audio_stream_params *dp_queue_get_audio_params(struct dp_queue *dp_queue)
{
CORE_CHECK_STRUCT(dp_queue);
return &dp_queue->audio_stream_params;
}

/**
* @brief return true if the queue is shared between 2 cores
*/
Expand Down