Tools: Tune: EQ: Normalize IIR and FIR separately #9086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more freedom to scale the equalizers. Common criteria resulted with safe scaling to unnecessarily silent result or risk for audible clipping in the equalizer. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
ShriramShastry
approved these changes
May 3, 2024
| @@ -87,8 +87,8 @@ function cmocka_data_eq_iir() | |||
| eq = eq_defaults(); | |||
| eq.fs = fs; | |||
| eq.enable_iir = 1; | |||
| eq.norm_type = 'peak'; | |||
| eq.norm_offs_db = 1; | |||
| eq.iir_norm_type = 'peak'; | |||
There was a problem hiding this comment.
Suggestion, a check like below would be helpful
function [x, yi] = get_chirp(fs, t_chirp)
% To ensure that the sampling frequency is positive and non-zero.
if fs <= 0
error('Sampling frequency fs must be positive and non-zero.');
end
end
And redundant code inside
function [x, yi] = get_chirp(fs, t_chirp)
channels = 2;
imax = scale - 1;
imin = -scale;
| error('Requested IIR normalization is not supported'); | ||
| end | ||
| switch lower(eq.fir_norm_type) | ||
| case 'loudness' |
There was a problem hiding this comment.
The scaling factor calculations for FIR and IIR do not appear to account for possible zero values, which may result in division by zero (1/sens_iir or 1/m_lin_iir(i1k)). You might want to add a tick to avoid this.
Example:
>> eq.f = 48e3;
i1k = find(eq.f > 1e3, 1, 'first') - 1;
disp(i1k)
0
then
if sens_fir ~= 0
g_fir = 1/sens_fir;
else
error('Sensation level is zero for FIR, cannot normalize by loudness.');
end
For other's as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more freedom to scale the equalizers. Common criteria resulted with safe scaling to unnecessarily silent result or risk for audible clipping in the equalizer.