Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST][DNM] make 3 components modular #9296

Closed
wants to merge 12 commits into from
Closed

[TEST][DNM] make 3 components modular #9296

wants to merge 12 commits into from

Commits on Jul 11, 2024

  1. llext: fix Windows builds 

    Under windows the Python interpreter has to be called explicitly.
Without it an attempt to execute a Python script fails silently.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b7e4837 View commit details
    Browse the repository at this point in the history

  2. ipc4: a failure to find a driver might not be fatal 

    When ipc4_get_drv() fails to find a driver, it might mean, that the
driver needs to be linked dynamically. Printing an error in such a
case wrongly fails CI testing.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b95d626 View commit details
    Browse the repository at this point in the history

  3. samples: (cosmetic) clean up Kconfig spacing 

    Use consistent TABs and spaces in src/samples/audio/Kconfig

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    95a0aeb View commit details
    Browse the repository at this point in the history

  4. llext: add maximum instance count support 

    Maximum instance count cannot be zero, they have to be supplied by
respective modules.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    543272f View commit details
    Browse the repository at this point in the history

  5. rimage: propagate maximum module instance counts 

    Use maximum instance count from modules when building a manifest.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8891fb2 View commit details
    Browse the repository at this point in the history

  6. llext: remove logging during module freeing 

    When pipelines are destroyed, component drivers' .reset() and .free()
are called. If those drivers were loaded dynamically their memory is
then unmapped. But logging takes place in a low priority task, so it
is important that no logging is done from those methods.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b06f65b View commit details
    Browse the repository at this point in the history

  7. llext: disable when testing reproducible builds 

    So far we cannot build identical LLEXT modules under Linux and
Windows, build a monolithic firmware for this test.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    261dd24 View commit details
    Browse the repository at this point in the history

  8. kcps: fix 0 module CPC case 

    If a module contains 0 as its CPC value, the consumption calculation
routine will assign a "safe" maximum value to keep the DSP running at
the maximum clock rate. This works when constructing a pipeline, but
when a pipeline is torn down, returning the maximum clock rate leads
to the clock being reduced to a small value. Fix this by detecting
such cases in pipeline termination code.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    918bf13 View commit details
    Browse the repository at this point in the history

  9. llext: make 3 components modular by default on MTL 

    Make smart-amp-test, mixin-mixout and eq-iir modular on MTL.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    de7e4a7 View commit details
    Browse the repository at this point in the history

  10. perf: fix SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS=n 

    With CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS=n compilation is
currently broken, fix it.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2d727e5 View commit details
    Browse the repository at this point in the history

  11. llext: disable performance, it breaks llext 

    When built with performance-measurement enabled, LLEXT fails to boot.
Disable CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS until it's
fixed.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5a62148 View commit details
    Browse the repository at this point in the history

  12. Disable KCPS_DYNAMIC_CLOCK_CONTROL to test speaker-test 

    Disabling CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL appears to fix
speaker-test failures with LLEXT.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
    @lyakh
    lyakh committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8bb79f8 View commit details
    Browse the repository at this point in the history