Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology2: sof-hda-generic: support BT offload pipelines #9337

Closed
wants to merge 1 commit into from

Conversation

brentlu
Copy link
Contributor

@brentlu brentlu commented Jul 29, 2024

Add pipelines for BT offload on SSP2. The topology file name will be sof-hda-generic-2ch-bt-ssp2.tplg or sof-hda-generic-4ch-bt-ssp2.tplg according to DMIC PCM channel number.

cc:

@brentlu
Copy link
Contributor Author

brentlu commented Jul 29, 2024

Linux PR to support this topology: thesofproject/linux#5123

@brentlu
Copy link
Contributor Author

brentlu commented Jul 29, 2024

It seems to me that there are three types of HDA topologies:

sof-hda-generic: platforms before cavs2.5
sof-hda-generic-cavs25: cavs2.5 platforms (TGL, ADL)
sof-hda-generic-ace1: ace1 and ace2 (MTL, LNL)

Should I apply my changes to sof-hda-generic-ace1 and leave other two topologies untouched?

@brentlu brentlu added the Bluetooth audio Bluetooth audio offload via SOF DSP label Jul 29, 2024
@plbossart
Copy link
Member

It seems to me that there are three types of HDA topologies:

sof-hda-generic: platforms before cavs2.5 sof-hda-generic-cavs25: cavs2.5 platforms (TGL, ADL) sof-hda-generic-ace1: ace1 and ace2 (MTL, LNL)

Should I apply my changes to sof-hda-generic-ace1 and leave other two topologies untouched?

IIRC the changes are only related to the DMIC blobs. @ujfalusi can you confirm?

But there's the same objection that for topology1, MTL is a done deal, we can't distribute a new topology that requires an update to the kernel machine driver and topology selection in the SOF driver.

The dependency between machine driver and topology make this sort of change very complicated.

And then there's the question of where do we stop? Why not add BT Offload for SoundWire devices then? It's a nightmare really to add such capabilities on platforms that shipped already without breaking anything.

Add pipelines for BT offload on SSP2. The topology file name will be
sof-hda-generic-2ch-bt-ssp2.tplg or sof-hda-generic-4ch-bt-ssp2.tplg
according to DMIC PCM channel number.

Signed-off-by: Brent Lu <brent.lu@intel.com>
@brentlu brentlu closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bluetooth audio Bluetooth audio offload via SOF DSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants